git commit message conventions

Joseph Myers joseph@codesourcery.com
Wed Jun 3 15:00:00 GMT 2015


On Wed, 3 Jun 2015, Carlos O'Donell wrote:

> I think your proposal is great, but we already require this?
> 
> https://sourceware.org/glibc/wiki/Committer%20checklist#Create_a_Proper_Commit_Message
> 
> https://sourceware.org/glibc/wiki/GlibcGit#Commit_Messages
> 
> Do we need to remind people to follow the Committer Checklist?

Maybe we do.  I see lots of commits with only a single line although 
there's a more substantial description on libc-alpha (commits to master, 
that is; what people do on their own branches is up to them).  I see quite 
a few where people fail to use --author when committing for other people.  
I see the occasional commit where the first line isn't a useful patch 
description at all, but is either the author line from the ChangeLog 
entry, or the first content line from the ChangeLog entry (possibly a line 
just saying [BZ #N]).

> Do we need to update the Contribution Checklist to remind people
> that their email will become the commit message?

That seems sensible as well.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list