[PATCH] fix BZ 18116 - build failure on ppc64le: setcontext.S uses power6 mtfsf when not supported
Joseph Myers
joseph@codesourcery.com
Mon Jun 1 20:11:00 GMT 2015
On Mon, 1 Jun 2015, Tulio Magno Quites Machado Filho wrote:
> Steven Munroe <munroesj@linux.vnet.ibm.comcom> writes:
> > On Wed, 2015-03-18 at 10:52 -0600, Martin Sebor wrote:
> >> > I mean around each instance of mtfsf 0xff,fp0,1,0
> >> >
> >> > What you suggested is only correct and safe for IBM POWER hardware
> >> > Power6 and later. It is not safe or correct for powerpc64 chips from
> >> > other manufacturer that implement a subset of the PowerISA-2.05 (or
> >> > later).
> >>
> >> I suspect you've misread the changes in the first patch.
> >>
> >> The first and the third patches are equivalent and after
> >> preprocessing will result in the assembler seeing the
> >> exact same code, including directives, regardless of what
> >> the target cpu is.
> >>
> >
> > The 3rd patch dated March 16th is good.
>
> Committed as db8fed87d9741b6b3da6c2257f01d63ef2fe407c.
If this fully fixes the bug, remember to update the list of fixed bugs in
NEWS and to close the bug as fixed.
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Libc-alpha
mailing list