[PATCH] powerpc: strcasestr optimization

[Steven Munroe]

On Mon, 2015-06-01 at 14:28 +0200, Ondřej Bílka wrote:
> On Mon, Jun 01, 2015 at 04:11:28PM +0530, Rajalakshmi Srinivasaraghavan wrote:
> > 
> > This patch optimizes strcasestr function for power >= 7 systems.
> > This patch uses optimized strlen and strnlen for calculating
> > string length and the average improvement of this optimization is ~40%.
> > This patch is tested on powerpc64 and powerpc64le.
> > Attached the benchresults with this new patch.
> > 
> Thats not enough. As strcasestr that I submited is around three times
> slower your implementation would likely be regression over generic one.
> 
> A problem here is that you use moronic algorithm. Fix algorithm first
> before trying to optimize it.
> 

This is not very helpful. You are demanding changes without clear
explanation and justification.

What is wrong with Raja's algorithm? What is insufficient in the
benchmark data she has provided? And why do you think your specific
design applies to PowerISA and POWER7/POWER8 micro-architecture.

What data do you have that justified this objection?