[PATCH][PING] Inline C99 math functions

Joseph Myers joseph@codesourcery.com
Wed Jul 22 19:47:00 GMT 2015


On Wed, 22 Jul 2015, Wilco Dijkstra wrote:

> > I don't see an updated ChangeLog entry (with the [BZ #N] notation I
> > requested).  Please include the ChangeLog entry with each patch
> > submission.
> 
> It was still in the quotes. Something like this?
> 
> 2015-07-xx  Wilco Dijkstra  <wdijkstr@arm.com>
> 
> 	* math/Makefile: Build test-snan.c with -fsignaling-nans.
> 	* math/math.h (fpclassify): Use __builtin_fpclassify when
> 	available.  (signbit): Use __builtin_signbit(f/l).
> 	(isfinite): Use__builtin_isfinite.  (isnormal): Use
> 	__builtin_isnormal.  (isnan): Use __builtin_isnan - fixes [BZ #17441].
> 	(isinf): Use __builtin_isinf_sign - fixes [BZ #15367].

That's not the style used (and your line breaks are all wrong).  
<TAB>[BZ #N]<LF> at the start of the ChangeLog entry, after the initial 
author-date line and blank line and before the lines describing changes to 
each file.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list