[PATCH] Fix sparc build
David Miller
davem@davemloft.net
Wed Jul 15 23:05:00 GMT 2015
From: Roland McGrath <roland@hack.frob.com>
Date: Wed, 15 Jul 2015 15:45:53 -0700 (PDT)
>> * sysdeps/sparc/sparc32/sparcv9/bits/atomic.h (atomic_spin_nop): Remove space from
>
> This line is too long.
Ok.
>> +ifeq ($(subdir),nscd)
>> +routines += cpu_relax
>> +endif
>
> I think this merits a comment explaining that atomic_spin_nop (or you could
> just say "direct uses of our internal <atomic.h> interfaces") requires
> cpu_relax and that nscd uses those internal interfaces directly.
I'll add a comment.
> Otherwise looks fine and I think it clearly falls under Carlos's rules for
> freeze-time commits without his explicit approval.
Thanks, will commit after I fix the above.
More information about the Libc-alpha
mailing list