[PATCH] Fix ruserok scalability with large ~/.rhosts file.

Mike Frysinger vapier@gentoo.org
Wed Jul 8 06:30:00 GMT 2015


On 18 Jun 2015 11:50, Carlos O'Donell wrote:
> --- a/inet/rcmd.c
> +++ b/inet/rcmd.c
>
> +	/* First check the user part.  This is an optimization, since
> +	   one should always check the host first in order to detect
> +	   negative host checks (which we check for later).  */
> +	ucheck = __icheckuser (user, ruser);

the phrasing in this comment sounds confused, or maybe misleading ?

> +	    /* Next check host part */

style is incorrect (period/trailing space)

otherwise patch looks fine to me
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20150708/b14eba8f/attachment.sig>


More information about the Libc-alpha mailing list