[PATCHv5][PING^3][BZ #17833] _dl_close_worker() does not release inconsistent objects.

[Pavel Kopyl]

On 07/07/2015 09:10 PM, H.J. Lu wrote:
> On Tue, Jul 7, 2015 at 9:27 AM, Pavel Kopyl <p.kopyl@samsung.com> wrote:
>>
>> On 07/07/2015 06:30 PM, H.J. Lu wrote:
>>> On Tue, Jul 7, 2015 at 12:41 AM, Yury Gribov <y.gribov@samsung.com> wrote:
>>>> On 07/03/2015 02:46 AM, H.J. Lu wrote:
>>>>> On Thu, Jul 2, 2015 at 3:53 PM, Pavel Kopyl <p.kopyl@samsung.com> wrote:
>>>>>>
>>>>>>
>>>>>> On 06/30/2015 06:12 PM, H.J. Lu wrote:
>>>>>>>
>>>>>>> On Tue, Jun 30, 2015 at 7:45 AM, Pavel Kopyl <p.kopyl@samsung.com>
>>>>>>> wrote:
>>>>>>> This patch changes DF_1_NODELETE path.  Do we have a testcase for
>>>>>>> sucessfully loading/unloading DF_1_NODELETE DSO with undefined
>>>>>>> symbols?
>>>>>>>
>>>>>>> It may have been asked before.  Can we reset unique symbols
>>>>>>> in _dl_open before calling _dl_close_worker?
>>>>>>>
>>>>>> Yes, I added testcases for three possible ways where we can get
>>>>>> DF_1_NODELETE:
>>>>>> 1. Unique symbols
>>>>>> 2. Load with RTLD_NODELETE flag.
>>>>>> 3. Link with '-z nodelete' option
>>>>>>
>>>>>>> Can we reset unique symbols in _dl_open before calling
>>>>>>> _dl_close_worker?
>>>>>> But I clear unique symbols exactly in
>>>>>> _dl_close_worker.<https://slovari.yandex.ru/exactly/en-ru>
>>>>>>
>>>>>>
>>>>> Looks good to me.
>>>>
>>>> Folks,
>>>>
>>>> Could someone commit the patch for us?  We do not have write access to
>>>> Glibc
>>>> repo.  We'll be around to cope with bugs (if any).
>>>>
>>> Please regenerate the patch with "gcc format-patch" and resubmit it
>>> so that I can do "git am your-patch".
>>>
>>> Thanks.
>> Thanks a lot.
> I reformatted your change, fixed ChangeLog entry and added a commit log.
> This is what I checked in.
>
> Please provide proper ChangeLog and commit log next time.
>
> Thanks.
>
Thank you for clarification.
I wonder how should I format patch if I need to mention several authors?

-Pavel