[PATCH][BZ #18508] S390: Fix "backtrace() returns infinitely deep stack frames with makecontext()".
Florian Weimer
fweimer@redhat.com
Fri Jul 3 09:11:00 GMT 2015
On 06/15/2015 10:47 AM, Stefan Liebler wrote:
> +/* We do not want .eh_frame info for __makecontext_ret to stop unwinding
> + if backtrace() was called within a context created by makecontext.
> + (there is also no .eh_frame info for _start or thread_start) */
> +/* We do not want .eh_frame info for __makecontext_ret to stop unwinding
> + if backtrace() was called within a context created by makecontext.
> + (there is also no .eh_frame info for _start or thread_start) */
I think this should read:
âWe do not want .eh_frame ifno so that __makecontext_ret stops unwinding
if backtrace was called within a context created by makecontext. (There
is also no .eh_frame info for _start or thread_start.)â
Could a native speaker review this, please?
Rest of the patch seems okay to me.
--
Florian Weimer / Red Hat Product Security
More information about the Libc-alpha
mailing list