[PATCH] Initialize nscd stats data [BZ #17892]

Siddhesh Poyarekar siddhesh@redhat.com
Wed Jan 28 17:45:00 GMT 2015


On Wed, 28 Jan 2015 10:18:53 +0100
Andreas Schwab <schwab@suse.de> wrote:

> Siddhesh Poyarekar <siddhesh@redhat.com> writes:
> 
> > nscd stats data that is sent from the daemon to the binary invoked
> > with 'nscd -g' does not always initialize selinux data.  Valgrind
> > complains about it, so just initialize the entire struct once to
> > get rid of that warning.  I haven't done a full analysis of the
> > code changed, but the net change in the code size of the send_stats
> > function is just 2 bytes.  The valgrind warning:
> 
> I don't think this has anything to do with selinux data, it's just
> complaining about uninitialised padding bytes, doesn't it?

Ahh yes, it's not the selinux data, it is the padding bytes in the
struct.  So initializing the entire struct would in fact be the best
way to fix this warning.

Siddhesh



More information about the Libc-alpha mailing list