[PATCH v3 1/4] Nios II port re-submission, sysdeps/nios2

[Chung-Lin Tang]

On 2015/1/10 02:29 AM, Joseph Myers wrote:
> On Sat, 10 Jan 2015, Chung-Lin Tang wrote:
> 
>>         * sysdeps/nios2/soft-fp/sfp-machine.h: New file.
> 
> As Roland noted in 
> <https://sourceware.org/ml/libc-alpha/2014-10/msg00369.html>, soft-fp 
> subdirectories that are always used are redundant - the files in them can 
> be moved one level up, and the entries in Implies removed.

Fixed.

> Some new files have the copyright notice as their first line.  The first 
> line should be a description of the file (like you have in 
> sysdeps/nios2/bits/setjmp.h, for example), with the copyright notice as 
> the next line.

I've added brief descriptions to most files this time, mostly in line to
what other ports have done.

>> +libc {
>> +  GLIBC_2.20 {
>> +    __adddf3; __addsf3; __divdf3; __divsf3; __eqdf2; __eqsf2; __extendsfdf2;
...
> 
> Should be GLIBC_2.21 (it's least confusing for Versions entries used only 
> on one system to reflect the actual symbol versions on that system, even 
> though references to older versions should get automatically adjusted when 
> glibc is built).

Fixed.

>> +/* XXX Until we have a better place keep the definitions here.  */
>> +#define __exit_thread_inline(val) \
>> +  INLINE_SYSCALL (exit, 1, (val))
> 
> This was removed from pthreaddef.h on 2014-05-13.  Watch out for any other 
> such global changes for which there should be port updates....

Removed. I went over the ChangeLogs during that time again, and so far
cannot find other such cases. I'll be ready to fix them should more be
found.

Attached is the updated patch, sysdeps/nios2 portions. Only a single
change in the sfp-machine.h path in the ChangeLog, so not repeating it
whole here.

Thanks,
Chung-Lin


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01a-sysdeps-nios2.patch
Type: text/x-patch
Size: 96826 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20150113/98a37295/attachment.bin>