Missing security fix in elf/dl-open.c?

[Carlos O'Donell]

On 02/28/2015 11:23 AM, Allan McRae wrote:
> On 28/02/15 06:41, Carlos O'Donell wrote:
>> On 02/27/2015 02:21 PM, Florian Weimer wrote:
>>> On 02/27/2015 05:43 PM, Carlos O'Donell wrote:
>>>>> However, something else already does this in Fedora 20
>>>>> (glibc-2.20-7.fc21.x86_64, which lacks this patch as well AFAICT).  I
>>>>> created a SUID binary with an $ORIGIN RPATH, and it is ignored, but only
>>>>> when actually running SUID.
>>>>
>>>> Likely the `glibc-fedora-elf-ORIGIN.patch` patch in Fedora.
>>>
>>> Oooh!  Does it mean we should upstream this patch instead?
>>
>> Yes, and that includes reviewing exactly what it does :-)
>>
> 
> Here is the original submission:
> https://sourceware.org/ml/libc-hacker/2010-12/msg00001.html
> 
> The discussion was not very helpful.

Andreas,

Do you remember the rationale for the change in [1]?

Cheers,
Carlos.

[1] https://sourceware.org/ml/libc-hacker/2010-12/msg00001.html