Corrupted test cases since "Don't require test wrappers to preserve environment variables, use more consistent environment" heaps
Mel Gorman
mgorman@suse.de
Tue Feb 24 16:08:00 GMT 2015
On Tue, Feb 24, 2015 at 02:35:58PM +0000, Joseph Myers wrote:
> On Tue, 24 Feb 2015, Mel Gorman wrote:
>
> > The test case does not crash but it's clearly corrupted.
> >
> > Before that commit we have
> >
> > mel@stampy:~/git-public/glibc > rm -rf obj-verify; git checkout 8540f6d2a74fe9d67440535ebbcfa252180a3172^ | head; mkdir obj-verify; cd obj-verify; ../configure --prefix=/tmp/blah > /dev/null 2>&1 && make -j8 > /dev/null 2>&1 && make -j8 tests > /dev/null 2>&1 ; ./testrun.sh > ./intl/tst-gettext4; cd ..
> > HEAD is now at ed36bfa18faf... PowerPC: Fix optimized strncat strlen call
> > beauty
> > thread 1 call 1 returned: beauty
> > beauty
> > thread 2 call 1 returned: beauty
> > beauty
> > thread 1 call 2 returned: beauty
> > beauty
> > thread 2 call 2 returned: beauty
>
> This is the output when the test fails; "thread 1 call 1 returned" etc.
> are failure messages. Before my commit, testrun.sh was not by itself a
> correct way of running this test, because it lacked the environment setup
> required by this test; that environment setup was local to the
> tst-gettext4.sh script.
>
Sorry for the noise. The actual problem is my patch due to the fact that
extra can go negative.
--
Mel Gorman
SUSE Labs
More information about the Libc-alpha
mailing list