[patch] Fix BZ#16374 -- don't use mmap for FILE buffers

[Joseph Myers]

On Mon, 16 Feb 2015, Carlos O'Donell wrote:

> On 02/16/2015 01:51 PM, Paul Pluzhnikov wrote:
> > On Mon, Feb 16, 2015 at 10:28 AM, Carlos O'Donell <carlos@redhat.com> wrote:
> > 
> >> This patch is not OK as-is, and needs to be split into multiple patches.
> >>
> >> One patch for the calloc/free changes, and another with much much much
> >> more detail for the semantic changes that fix input-only unclean buffers.
> > 
> > The first patch will break 3 (mtrace) tests, and the second will then
> > fix them. Is that ok?
> 
> Yes, post them as 0/2 (descriptions), 1/2 (conversion), and 2/2 (bug fix).

No, we want bisectability and should seek to avoid any commits on master 
that introduce test failures.

If the bug fixes can go first (even if the bugs being fixed are latent at 
present), then do them before the conversion, not after.  If they can't go 
first then they may need to go in the same patch as the conversion.

(If there weren't existing tests involved then splitting in your order 
would work, with patch 2/2 being the one adding the new tests.)

-- 
Joseph S. Myers
joseph@codesourcery.com