[patch] Fix BZ#16374 -- don't use mmap for FILE buffers

[Florian Weimer]

On 02/16/2015 07:51 PM, Paul Pluzhnikov wrote:
> On Mon, Feb 16, 2015 at 10:32 AM, Florian Weimer <fweimer@redhat.com> wrote:
> 
>>> Attached patch replaces mmap()s with calloc()s.
>>
>> Why is calloc needed?
> 
> In previous discussion it was mentioned that something was expecting
> the buffers to be zero'ed out, but you are right -- fallback used
> malloc and calloc shouldn't be necessary (this should nicely speed
> things up on systems with large pages :)

I think it will still be a net win, but fopen/fclose pairs might now run
into the issue discussed in the ‘Reduce worst-case behaviour with
madvise and refault overhead’ thread. :-P

-- 
Florian Weimer / Red Hat Product Security