[PATCH] powerpc: Fix inline feraiseexcept, feclearexcept macros

Joseph Myers joseph@codesourcery.com
Wed Feb 11 21:58:00 GMT 2015


On Mon, 9 Feb 2015, Adhemerval Zanella wrote:

> Ping (with NEWS adjusted to 2.22).
> 
> > Indeed, I have dropped the conditionals (I used test-fenv.c as base, but I think
> > in this context they are not really required).
> >
> > Tested on powerpc64 with fix for BZ#17885 applied.
> >
> > --
> >
> > 	[BZ #17776]
> > 	* sysdeps/powerpc/bits/fenvinline.h (feraiseexcept): Convert input to
> > 	integer before bitwise and assembly operations.
> > 	(feclearexcept): Likewise.
> > 	* math/test-fenvinline.c: New file.
> > 	* math/Makefile: Add test-fenvinline test.

OK, though I think we could do for test coverage for the other functions 
taking an integer argument (fetestexcept fesetround feenableexcept 
fedisableexcept), to protect against this type of bug appearing for any 
of them in future.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list