[PATCH COMMITTED] malloc: Update comment for list_lock

Florian Weimer fweimer@redhat.com
Wed Dec 23 16:29:00 GMT 2015


On 12/22/2015 09:16 PM, Carlos O'Donell wrote:
> On 12/22/2015 02:32 PM, Florian Weimer wrote:
>> On 12/21/2015 10:54 PM, Carlos O'Donell wrote:
>>
>>>> +   list_lock also prevents concurrent forks.  When list_lock is
>>>> +   acquired, no arena lock must be acquired, but it is permitted to
>>>> +   acquire arena locks after list_lock.  */
>>>
>>> This last sentence seems ambiguous to me. I assume you mean to say that
>>> at the point at which list_lock is acquired there are no other arena
>>> locks held, but that after list_lock is acquired, other arena locks may
>>> be acquired afterwards?
>>
>> That was my intent.  Is this clearer?
>>
>>   list_lock also prevents concurrent forks.  At the time list_lock is
>>   acquired, no arena lock must have been acquired, but it is permitted
>>   to acquire arena locks subsequently, while list_lock is acquired.
>>
>> I'm following Torvald's earlier guidance not to speak of “held” locks.
> 
> Looks good to me.

Thanks, committed.

Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-malloc-Update-comment-for-list_lock.patch
Type: text/x-patch
Size: 1573 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20151223/8e7743f8/attachment.bin>


More information about the Libc-alpha mailing list