[PATCH] Fix broken overflow check in posix_fallocate

[Carlos O'Donell]

On 08/26/2015 02:47 AM, Florian Weimer wrote:
> On 08/26/2015 08:42 AM, Paul Eggert wrote:
>> * sysdeps/posix/posix_fallocate.c (posix_fallocate):
>> * sysdeps/posix/posix_fallocate64.c (__posix_fallocate64_l64):
>> Fix parenthesization typo.
>> ---
>>  ChangeLog                         | 5 +++++
>>  sysdeps/posix/posix_fallocate.c   | 2 +-
>>  sysdeps/posix/posix_fallocate64.c | 2 +-
>>  3 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/ChangeLog b/ChangeLog
>> index bd6d027..458b850 100644
>> --- a/ChangeLog
>> +++ b/ChangeLog
>> @@ -1,5 +1,10 @@
>>  2015-08-25  Paul Eggert  <eggert@cs.ucla.edu>
>>  
>> +	Fix broken overflow check in posix_fallocate
>> +	* sysdeps/posix/posix_fallocate.c (posix_fallocate):
>> +	* sysdeps/posix/posix_fallocate64.c (__posix_fallocate64_l64):
>> +	Fix parenthesization typo.
> 
> Please add the BZ #18873 reference before committing (also to NEWS).
> 
> I don't recognize this changelog format.  Not sure if that's matching
> the standards.

In some GNU projects they encourage a general paragraph before the change
list to explain the fix. The GNU Coding Standard is silent about this
kind of additional text. We allow it, but I think Paul is the only one
who does this :-)

c.