[PATCH 1/3] Replace BZERO_P/PIC with USE_AS_BZERO/SHARED

H.J. Lu hjl.tools@gmail.com
Wed Aug 26 14:38:00 GMT 2015


On Wed, Aug 26, 2015 at 6:59 AM, Ondřej Bílka <neleai@seznam.cz> wrote:
> On Wed, Aug 26, 2015 at 06:43:31AM -0700, H.J. Lu wrote:
>> Replace BZERO_P with USE_AS_BZERO in i586/i686 memset.S to support i386
>> multi-arch memset.  Also we should check SHARED not PIC for libc.so
>> since libc.a may be compiled with PIC.
>>
>> OK for master?
>>
> This is ok as patch.
>
> However as I noted in x64 memset this is ineffective as it doubles code
> size for mostly identical code. So as followup one needs to create bzero
> stub that jumps into memset. Should I do it?

IA32 doesn't pass argument in registers.   Can we have a second
entry point in memset for bzero?

-- 
H.J.



More information about the Libc-alpha mailing list