[PATCH v3][BZ 13690] Do not violate mutex destruction requirements.

Torvald Riegel triegel@redhat.com
Mon Aug 24 07:43:00 GMT 2015


On Mon, 2015-08-24 at 09:32 +0200, Andreas Schwab wrote:
> Torvald Riegel <triegel@redhat.com> writes:
> 
> > diff --git a/sysdeps/unix/sysv/linux/lowlevellock-futex.h b/sysdeps/unix/sysv/linux/lowlevellock-futex.h
> > index 59f6627..e1a9c58 100644
> > --- a/sysdeps/unix/sysv/linux/lowlevellock-futex.h
> > +++ b/sysdeps/unix/sysv/linux/lowlevellock-futex.h
> > @@ -54,8 +54,13 @@
> >  #if IS_IN (libc) || IS_IN (rtld)
> >  /* In libc.so or ld.so all futexes are private.  */
> >  # ifdef __ASSUME_PRIVATE_FUTEX
> > -#  define __lll_private_flag(fl, private) \
> > -  ((fl) | FUTEX_PRIVATE_FLAG)
> > +#  define __lll_private_flag(fl, private)			\
> > +  ({								\
> > +    /* Prevent warnings in callers of this macro.  */		\
> > +    int __lll_private_flag_priv __attribute__ ((unused));	\
> > +    __lll_private_flag_priv = private;				\
> 
> Macro parameters should be parenthesized.

You're right, obviously.  Update attached.

On the positive side, this patch is small enough that I should
eventually run out of opportunities for stupid mistakes like this one ;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mutex-destruction.patch
Type: text/x-patch
Size: 7080 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20150824/f7aa5ec8/attachment.bin>


More information about the Libc-alpha mailing list