Don't use -Wno-uninitialized in math/

Joseph Myers joseph@codesourcery.com
Fri Aug 21 16:10:00 GMT 2015


On Fri, 21 Aug 2015, Steve Ellcey wrote:

> On Thu, 2015-08-20 at 18:00 +0000, Joseph Myers wrote:
> > The uninitialized variable warnings in math/ having been fixed for all
> > the supported floating-point formats, this patch removes the use of
> > -Wno-uninitialized there, continuing with the goal of avoiding -Wno-
> > options in makefiles as far as possible..
> > 
> > Tested for x86_64 and x86 (full build and testsuite runs), and for
> > powerpc and mips64 (verified that glibc builds without errors).  
> > Committed.
> 
> I am seeing a mips32 build failure (using Top-of-tree GCC) with this
> change:
> 
> In file included from ../soft-fp/soft-fp.h:321:0,
>                  from ../soft-fp/fmatf4.c:30,

mips32 shouldn't be using fmatf4; sysdeps/mips/ieee754/s_fmal.c even has a 
#error to make sure of this.  Do you mean mips64?

There are also diagnostic control macros in fmatf4.c specifically to 
disable this warning, so you'll need to look at why those aren't working 
for you.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list