[PATCH 2/6] Optimize i386 syscall inlining

Joseph Myers joseph@codesourcery.com
Fri Aug 21 12:35:00 GMT 2015


You define INLINE_SYSCALL_ERROR_RETURN to ignore the specified return 
value.  There is nothing in the comments on the default version of that 
macro in sysdeps/unix/sysdep.h to say that it is OK to ignore the return 
value.  If the return value must always be -1, I think the macro should 
take one fewer argument rather than having specified semantics that the 
last argument must always be -1, or that the macro may return -1 and 
ignore the last argument.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list