[PING][PATCH] Fix strcpy_chk and stpcpy_chk performance.

[Joseph Myers]

On Wed, 19 Aug 2015, Adhemerval Zanella wrote:

> Could you also get rid of the k&r function prototype (same for strcpy_chk) ?

I'm not really convinced it's good to mix such fixes with changes for 
other things (at least it shouldn't be required).

Ondřej had some automation for fixing such old-style definitions, see e.g. 
<https://sourceware.org/ml/libc-alpha/2013-06/msg00270.html>.  I think it 
would be good to try to get such changes in (eventually adding 
-Wold-style-definition to the warning options, possibly with an 
intermediate state of -Wold-style-definition 
-Wno-error=old-style-definition while architecture maintainers clean up 
their architectures) - starting with straightforward cases in files that 
do not use assertions (so changes to line numbers don't affect comparisons 
of generated code) and for which the changes do not affect the installed 
stripped shared libraries at all, then moving to other cases for which 
more careful review is needed.

-- 
Joseph S. Myers
joseph@codesourcery.com