[2.23 PATCH] Desupport regexp.h (bug 18681)

[Joseph Myers]

On Mon, 17 Aug 2015, Carlos O'Donell wrote:

> On 08/17/2015 12:53 PM, Joseph Myers wrote:
> > On Mon, 17 Aug 2015, Carlos O'Donell wrote:
> > 
> >> One of the big benefits of -Wundef -Werror was to prevent this kind
> >> of error from happening. We made the build use -Wundef, and that way
> >> if you failed to define the right things in Versions it would fail
> >> the build (see the problem we had with librt symbols in 2.18 that
> >> prompted the entire -Wundef work).
> >>
> >> How was Zack able to build glibc at all?
> > 
> > We never removed -Wno-error=undef, because while we got the glibc build 
> > itself clean from -Wundef warnings, we didn't achieve that for the 
> > testsuite.
> > 
> 
> Dag nabit. OK, I guess I know what I'm doing for 2.23.

I think Zack's misc/Versions patch plus my two testsuite patches are 
sufficient to eliminate -Wundef warnings on x86_64 and x86 (though I 
haven't done a build with -Wno-error=undef removed to make sure).

-- 
Joseph S. Myers
joseph@codesourcery.com