[PATCH 2/2] time/tst-strptime2.c: test full input range +/- 0-9999

Mike Frysinger vapier@gentoo.org
Sun Aug 16 14:31:00 GMT 2015


On 15 Aug 2015 12:42, James Perkins wrote:
> +static const char const *dummy_string = "1113472456";

the double const here doesn't make sense.  maybe you meant:
	static const char * const dummy_string = ...;

but really it looks like you want:
	static const char dummy_string[] = ...;

> +      extern bool verbose; \

you shouldn't need this since the code is all included below

> +      verbose = 1; \

verbose is a bool, so only use true & false.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20150816/f2933c72/attachment.sig>


More information about the Libc-alpha mailing list