[PATCH] Remove incorrect register mov in floorf on x86_64

H.J. Lu hjl.tools@gmail.com
Fri Aug 14 12:34:00 GMT 2015


On Fri, Aug 14, 2015 at 4:19 AM, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> On Fri, Aug 14, 2015 at 01:12:04PM +0200, Ondřej Bílka wrote:
>> It isn't incorrect, just dead move. Ok for me.
>
> No, it loads an arbitrary value (we don't know what is in %rax at that
> point) into %rdx and overwrites the struct address.
>

Thanks for catching it. I checked in your patch together with the same
fix for sysdeps/x86_64/fpu/multiarch/s_nearbyint.S


-- 
H.J.



More information about the Libc-alpha mailing list