[PATCH] getsysstats: use sysinfo() instead of parsing /proc/meminfo

Joseph Myers joseph@codesourcery.com
Thu Aug 13 14:53:00 GMT 2015


On Thu, 13 Aug 2015, Rasmus Villemoes wrote:

> +sysinfo_mempages(unsigned long int num, unsigned int mem_unit)

Missing space before '('.  Appears several times in this patch.

How was this patch tested?  I'd have expected linknamespace test failures 
from the calls to sysinfo (that is, I'd expect you to need to make sysinfo 
into a weak alias for __sysinfo and call __sysinfo here to avoid such 
namespace issues).

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list