Fix BZ 18820 -- fmemopen may leak memory on failure

Ondřej Bílka neleai@seznam.cz
Thu Aug 13 06:39:00 GMT 2015


On Wed, Aug 12, 2015 at 11:28:48PM -0700, Paul Pluzhnikov wrote:
> On Wed, Aug 12, 2015 at 11:13 PM, Ondřej Bílka <neleai@seznam.cz> wrote:
> > On Wed, Aug 12, 2015 at 10:00:31PM -0700, Paul Pluzhnikov wrote:
> 
> >> I split out the "fix leak" part of BZ #18757 fix from
> >> https://sourceware.org/ml/libc-alpha/2015-08/msg00315.html
> >>
> >> Tested on Linux/x86_64, no new failures.
> >>
> >> Thanks,
> >>
> > Patch itself is ok but I found other bug that we don't set error values
> > there that should also be fixed.
> 
> Sorry, I am not following.
> 
> This patch is explicitly to only fix the leak. The set errno is
> separate bug and separate patch (which I'll send once this one is in
> -- it depend on this test case).
> 
> So is this patch OK as is, or are there other leaks that I am missing?
> 
yes. Its ok as it is but we need other patch to set error values.



More information about the Libc-alpha mailing list