[PATCH] i386: Assembly Implementation cleanup

[Torvald Riegel]

On Tue, 2015-08-11 at 17:22 -0700, H.J. Lu wrote:
> On Fri, Jul 3, 2015 at 8:41 AM, Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
> > This patch removes i386 assembly implementation for epoll_wait, mmap,
> > mmap64, semtimeop now that i386 have 6 argument syscall support from
> > C code.
> >
> > The mmap implementation used is the wordsize-32 generic linux one.
> >
> > Tested in i386.
> >
> > ---
> >
> >         * sysdeps/unix/sysv/linux/i386/mmap.c: New file.
> >         * sysdeps/unix/sysv/linux/i386/epoll_pwait.S: Remove file.
> >         * sysdeps/unix/sysv/linux/i386/mmap.S: Likewise.
> >         * sysdeps/unix/sysv/linux/i386/mmap64.S: Likewise.
> >         * sysdeps/unix/sysv/linux/i386/semtimedop.S: Likewise.
> >
> 
> What is the motivation?  6 argument syscalls aren't really inlined.
> They put arguments on stack and call __libc_do_syscall.  It is
> slower than assembly code.

Does this matter for any of those functions?  Are they typically called
on fast paths that would notice that?  If not, I think ease of
maintenance is more worthwile.