[PATCH] i386: Assembly Implementation cleanup

[Adhemerval Zanella]

On 11-08-2015 21:22, H.J. Lu wrote:
> On Fri, Jul 3, 2015 at 8:41 AM, Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
>> This patch removes i386 assembly implementation for epoll_wait, mmap,
>> mmap64, semtimeop now that i386 have 6 argument syscall support from
>> C code.
>>
>> The mmap implementation used is the wordsize-32 generic linux one.
>>
>> Tested in i386.
>>
>> ---
>>
>>         * sysdeps/unix/sysv/linux/i386/mmap.c: New file.
>>         * sysdeps/unix/sysv/linux/i386/epoll_pwait.S: Remove file.
>>         * sysdeps/unix/sysv/linux/i386/mmap.S: Likewise.
>>         * sysdeps/unix/sysv/linux/i386/mmap64.S: Likewise.
>>         * sysdeps/unix/sysv/linux/i386/semtimedop.S: Likewise.
>>
> 
> What is the motivation?  6 argument syscalls aren't really inlined.
> They put arguments on stack and call __libc_do_syscall.  It is
> slower than assembly code.
> 

Same for ARM: code maintainability on functions that are not really
performance-critical.  This avoids issues like the x86 pthread_cond_*
assembly implementation (which are now aimed to be removed), that
required specific fixes just for x86.