[PATCH v3] tzset robustness [BZ#17715]

[H.J. Lu]

On Fri, Apr 24, 2015 at 8:36 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 02/18/2015 11:46 AM, Florian Weimer wrote:
>> On 02/16/2015 11:51 PM, Paul Eggert wrote:
>>> Florian Weimer wrote:
>>>> So I'm not sure what to do here.  Get rid of the alloca?  That's going
>>>> to be more difficult to review.
>>>
>>> I haven't read the code carefully, but if the only reason for the alloca
>>> is to have a temporary string that one can munge by storing '\0' bytes
>>> at strategic locations, then I presume that one could rewrite the code
>>> to avoid the need to make a temporary copy,
>>
>> Indeed.  I introduced __tzstring_len to avoid the need for the copy, and
>> broke down __tzset_parse_tz into several smaller functions.  Hopefully,
>> the control flow is more transparent.
>
> I've committed this now, with a few whitespace fixes.
>

This caused:

https://sourceware.org/bugzilla/show_bug.cgi?id=18333

-- 
H.J.