[PATCH 7/N v2] [x86_64] Vectorized math functions

Joseph Myers joseph@codesourcery.com
Fri Apr 24 20:30:00 GMT 2015


On Fri, 24 Apr 2015, Andrew Senkevich wrote:

> 2015-04-24 20:37 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
> > On Fri, 17 Apr 2015, Andrew Senkevich wrote:
> >
> >> My question is do we need to test this new SSE2 version (which is just
> >> simple wrapper to scalar one)?
> >
> > Well, we need to test each entry point.  One of the existing deficiencies
> > of IFUNC testing (which would also apply to the CPU tests here) is that we
> > don't test the different variants of libm functions for different
> > processors - I don't think you need to address that in your patch.  (So
> > make sure the SSE2 entry point is tested, but which function that testing
> > calls may depend on the processor.)
> 
> Yes, if not build separate test for SSE2 entry point then SSE2 version
> will be tested only on according processor if called through IFUNC.
> 
> Do we need to move to multiarch folder implementations with IFUNC?

In general use of IFUNCs is the preferred way of handling different 
function implementations for different CPU variants, in the absence of a 
clear reason to do it differently in a particular case.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list