[PATCH] Do not build with -Winline
Florian Weimer
fweimer@redhat.com
Fri Apr 24 15:09:00 GMT 2015
On 04/24/2015 05:01 PM, Paul Eggert wrote:
> Florian Weimer wrote:
>> Per the previous discussion.
>
> This patch looks good to me. In other GNU projects we've found that
> -Winline is more trouble than it's worth. Like
> -Wunsafe-loop-optimizations, all that -Winline tells you is that
> generated code is not quite as efficient as it might be under ideal
> conditions, which is not a big deal, certainly not worth breaking a
> build over.
Thanks, committed.
It's even worse, -Winline warns for cases where the code is, in fact,
optimal (not inlining a non-trivial function called multiple times from
unlikely code is often beneficial).
--
Florian Weimer / Red Hat Product Security
More information about the Libc-alpha
mailing list