[PATCHv3][PING^5][BZ #17833] _dl_close_worker() does not release inconsistent objects.

[H.J. Lu]

On Fri, Apr 24, 2015 at 3:33 AM, Pavel Kopyl <p.kopyl@samsung.com> wrote:
>
>
> On 03/03/2015 12:13 PM, Pavel Kopyl wrote:
>>
>>
>> On 03/01/2015 10:17 PM, Mike Frysinger wrote:
>>>
>>> On 27 Feb 2015 16:32, Pavel Kopyl wrote:
>>>>
>>>> --- /dev/null
>>>> +++ b/elf/tst-unique5lib.cc
>>>> @@ -0,0 +1,13 @@
>>>> +
>>>
>>> i know existing tests are bad examples, but lets try and start fixing
>>> that.
>>> namely, there should be a header here giving a quick overview of what it
>>> is
>>> exactly you're testing for, and a BZ reference.
>>>
>>>> +extern int not_exist ();
>>>> +
>>>> +inline int make_unique ()
>>>> +{
>>>> +  static int unique;
>>>> +  return ++unique;
>>>> +}
>>>> +
>>>> +int foo ()
>>>> +{
>>>> +  return make_unique () + not_exist ();
>>>> +}
>>>
>>> i don't know if this is just copy & pasting, but prototypes that do not
>>> intend
>>> to take args should always be (void).
>>> -mike
>>
>>
>> Thanks for review, I fixed that in patch v3.
>
> Ping.
>

Some comments:

1. The bug report is against STB_GNU_UNIQUE.  But I don't see STB_GNU_UNIQUE in
testcase.  I can't tell if the original STB_GNU_UNIQUE bug is fixed.
2. Your testcase ignores dlopen error.  Why should it work at all?
3. Your testcase doesn't use test-skeleton.c.

-- 
H.J.