[PATCH 1/4] Define INLINE_VSYSCALL on all ports

Roland McGrath roland@hack.frob.com
Wed Apr 15 22:26:00 GMT 2015


> 	* sysdeps/unix/sysv/linux/alpha/sysdep.h [INLINE_VSYSCALL]: Define
> 	INLINE_SYSCALL.

The [foo] syntax corresponds to an '#if foo' block.  The (foo) syntax is
what you use when foo is what you touched, whether it's a function,
variable, macro, type, or whatever.  A coherent entry for what the change
actually does would be:

	* sysdeps/unix/sysv/linux/alpha/sysdep.h (INLINE_VSYSCALL):
	New macro; just use INLINE_SYSCALL.

But repeating boilerplate like this across a lot of sysdeps files is
usually a sign that you're doing it wrong.  Why not instead have some
common place that does:

#ifndef INLINE_VSYSCALL
# define INLINE_VSYSCALL INLINE_SYSCALL
#endif

?



More information about the Libc-alpha mailing list