[PATCH 06/25] Add struct scratch_buffer and its internal helper functions

[Florian Weimer]

On 04/09/2015 12:18 PM, Stefan Liebler wrote:

> I have another issue with tst-scratch_buffer.c on s390-32 where size_t
> is an unsigned long with only 4 bytes:

Dave Miller reported that as well, see the parallel thread.

I need to figure out how to build glibc for 32-bit in a multi-arch
environment.  But 32-bit s390 could be tricky, again due to the binutils
2.24 environment.

> gcc tst-scratch_buffer.c -c
> ...
> tst-scratch_buffer.c: In function ‘do_test’:
> tst-scratch_buffer.c:133:8: error: large integer implicitly truncated to
> unsigned type [-Werror=overflow]
>         && unchanged_array_size (&buf, 1ULL << 32, 0)
>         ^
> tst-scratch_buffer.c:134:8: error: large integer implicitly truncated to
> unsigned type [-Werror=overflow]
>         && unchanged_array_size (&buf, 0, 1ULL << 32)))
>         ^
> cc1: all warnings being treated as errors
> 
> Can you change the test and use "1ULL << 31" or make the usage of "1ULL
> << 32" conditionally?

I have a patch that adds a cast to size_t, which suppresses the warning
on 32-bit platforms.

Using 1ULL << 31 would invalidate the test.

Can you make a change to the test, so that it compiles, and check if you
get the same inlining failure as Dave?

-- 
Florian Weimer / Red Hat Product Security