[PATCH] Use correct signedness in wcsncmp.

Andreas Schwab schwab@suse.de
Tue Apr 7 16:10:00 GMT 2015


Stefan Liebler <stli@linux.vnet.ibm.com> writes:

> 2015-04-07  Stefan Liebler  <stli@linux.vnet.ibm.com>
>
> 	* wcsmbs/wcsncmp.c (wcsncmp): Compare as wchar_t, not wint_t.
> 	  Use signed comparision instead of substraction to avoid
> 	  overflow bug.
> 	* localedata/tests-mbwc/tst_wcsncmp.c (tst_wcsncmp):
> 	  Take the sign of ret.
> 	* localedata/tests-mbwc/dat_wcsncmp.c (tst_wcsncmp_loc):
> 	  Do not expect precise return values. Only the sign matters.
> 	* wcsmbs/Makefile (strop-tests): Add wcsncmp.
> 	* wcsmbs/test-wcsncmp.c: New File.
> 	* string/test-strncmp.c: Add wcsncmp support.

Ok, thanks.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."



More information about the Libc-alpha mailing list