[PATCH 06/25] Add struct scratch_buffer and its internal helper functions

[Florian Weimer]

On 04/07/2015 03:18 PM, Stefan Liebler wrote:
> Hi Florian,
> 
> i get a build error on s390x:
> gcc scratch_buffer_grow_preserve.c -c
> ...
> scratch_buffer_grow_preserve.c: In function
> ‘__libc_scratch_buffer_grow_preserve’:
> scratch_buffer_grow_preserve.c:35:7: error: implicit declaration of
> function ‘memcpy’ [-Werror=implicit-function-declaration]
>        memcpy (new_ptr, buffer->__space, buffer->length);
>        ^
> scratch_buffer_grow_preserve.c:35:7: error: incompatible implicit
> declaration of built-in function ‘memcpy’ [-Werror]
> cc1: all warnings being treated as errors
> 
> #include <string.h> in malloc/scratch_buffer_grow_preserve.c solves this
> error. Please update scratch_buffer_grow_preserve.c.

Sorry about that.  I did build on ppc64, but building on s390x is
difficult for me due to the binutils 2.24 requirement.  I'm trying to
get a suitable machine reservation, but I'm not sure if that will succeed.

Should I commit this fix blindly, without testing it on s390x?

-- 
Florian Weimer / Red Hat Product Security