[PING][PATCH] [BZ #17596] mblen return code when n is zero

Stefan Liebler stli@linux.vnet.ibm.com
Tue Apr 7 14:19:00 GMT 2015


Hi,

the test localedata/tst_mbrlen fails with:
mbrlen:de_DE.ISO-8859-1:1:1:2:F:the return value is different from an 
expected value
mbrlen:de_DE.ISO-8859-1:1:2:2:S:PASSED
mbrlen:de_DE.ISO-8859-1:1:3:2:S:PASSED
mbrlen:de_DE.ISO-8859-1:2:1:2:F:the return value is different from an 
expected value
mbrlen:de_DE.ISO-8859-1:2:2:2:S:PASSED
mbrlen:de_DE.ISO-8859-1:2:3:2:S:PASSED
mbrlen:en_US.ANSI_X3.4-1968:1:1:2:F:the return value is different from 
an expected value
mbrlen:en_US.ANSI_X3.4-1968:1:2:2:S:PASSED
mbrlen:en_US.ANSI_X3.4-1968:1:3:2:S:PASSED
mbrlen:en_US.ANSI_X3.4-1968:2:1:2:F:the return value is different from 
an expected value
mbrlen:en_US.ANSI_X3.4-1968:2:2:1:S:PASSED
mbrlen:en_US.ANSI_X3.4-1968:2:2:2:S:PASSED
mbrlen:en_US.ANSI_X3.4-1968:2:3:1:S:PASSED
mbrlen:en_US.ANSI_X3.4-1968:2:3:2:S:PASSED
mbrlen:ja_JP.EUC-JP:1:1:2:S:PASSED
mbrlen:ja_JP.EUC-JP:1:2:2:S:PASSED
mbrlen:ja_JP.EUC-JP:1:3:2:S:PASSED
mbrlen:ja_JP.EUC-JP:2:1:2:S:PASSED
mbrlen:ja_JP.EUC-JP:2:2:2:S:PASSED
mbrlen:ja_JP.EUC-JP:2:3:2:S:PASSED
mbrlen:ja_JP.EUC-JP:3:1:2:F:the return value is different from an 
expected value
mbrlen:ja_JP.EUC-JP:3:2:2:S:PASSED
mbrlen:ja_JP.EUC-JP:3:3:1:S:PASSED
mbrlen:ja_JP.EUC-JP:3:3:2:S:PASSED

and test localedata/tst_mbrtowc fails with:
mbrtowc:de_DE.ISO-8859-1:1:1:3:F:Initialization failed - skipping this 
test case.
mbrtowc:de_DE.ISO-8859-1:2:1:3:F:Initialization failed - skipping this 
test case.

This patch change the expected results for mbrlen in case of passing n=0 
to -2. The initialization of tst_mbrtowc is changed in the same way.

Tested on s390/s390x.

Please commit.

Bye Stefan

---
2015-04-07  Stefan Liebler  <stli@linux.vnet.ibm.com>

	localedata/tests-mbwc/dat_mbrlen.c
	(tst_mbrlen_loc): Change expected result to -2
	in case of n == 0.
	localedata/tests-mbwc/tst_mbrtowc.c (tst_mbrtowc):
	Check result against -2 instead of 0.

On 04/03/2015 03:49 PM, Ondřej Bílka wrote:
> On Fri, Mar 06, 2015 at 05:36:46AM -0500, Mike Frysinger wrote:
>> On 27 Nov 2014 18:06, Ondřej Bílka wrote:
>>> Andreas, do you have more comments or could you commit it as it looks as
>>> correct fix?
>>
>> lets push it
>> -mike
>
> Done.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mbrtowc_tests_20150407.patch
Type: text/x-patch
Size: 1620 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20150407/7556a51e/attachment.bin>


More information about the Libc-alpha mailing list