[PATCH] malloc: additional unlink hardening for non-small bins [BZ #17344]

Florian Weimer fweimer@redhat.com
Wed Sep 10 18:39:00 GMT 2014


On 09/10/2014 08:10 PM, Roland McGrath wrote:
> I think it's best practice to put each condition inside a __builtin_expect
> separately, rather than to have a complex expression inside it (despite the
> contrary example a few lines up).  The change seems fine aside from that.

Thanks.  The generated code is the same, so I'm going to commit the 
version with two __builtin_expect expressions.

(Eventually, we have to convert malloc/ to __glibc_{,un}likely.)

-- 
Florian Weimer / Red Hat Product Security



More information about the Libc-alpha mailing list