In debug/tst-chk1 we purposely test gets and getwd?

[Carlos O'Donell]

It seems in debug/tst-chk1.c we purposely test gets
and getwd, but both of those trigger deprecation
warnings. It would be nice to eventually turn on 
-Werror.

To fix the warnings for debug/tstk-chk1.c would we
use something like this?

diff --git a/debug/tst-chk1.c b/debug/tst-chk1.c
index 3393153..2262cc4 100644
--- a/debug/tst-chk1.c
+++ b/debug/tst-chk1.c
@@ -730,6 +730,9 @@ do_test (void)
       exit (1);
     }
 
+  /* We purposely test gets, so ignore the warnings.  */
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
   if (gets (buf) != buf || memcmp (buf, "abcdefgh", 9))
     FAIL ();
   if (gets (buf) != buf || memcmp (buf, "ABCDEFGHI", 10))
@@ -741,6 +744,7 @@ do_test (void)
     FAIL ();
   CHK_FAIL_END
 #endif
+#pragma GCC diagnostic pop
 
   rewind (stdin);
 
@@ -1144,6 +1148,9 @@ do_test (void)
          CHK_FAIL_END
 #endif
 
+         /* We purposely test getwd, so ignore the warnings.  */
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
          if (getwd (getcwdbuf) != getcwdbuf
              || strcmp (getcwdbuf, fname) != 0)
            FAIL ();
@@ -1158,6 +1165,7 @@ do_test (void)
            FAIL ();
          CHK_FAIL_END
 #endif
+#pragma GCC diagnostic pop
        }
 
       if (chdir (cwd1) != 0)
---

I haven't checked what version of gcc added these
pragmas though, so I don't know what build version of
gcc we'd have to bump up to. I'm just looking at the
long term picture.

Cheers,
Carlos.