[RFC] pthread_once: Use unified variant instead of custom x86_64/i386

Torvald Riegel triegel@redhat.com
Mon Oct 20 16:36:00 GMT 2014


On Sun, 2014-10-19 at 18:37 -0700, Roland McGrath wrote:
> > +static int
> > +__attribute__((noinline))
> 
> Space before paren.
> 
> > +__pthread_once_slow (pthread_once_t *once_control, void (*init_routine) (void))
> 
> This needs a comment explaining why it's separate.  I would have expected
> the compiler to generate essentially the same code for the early bailout
> case marked with __glibc_likely.
> 
> > +  atomic_read_barrier();
> [...]
> > +    return __pthread_once_slow(once_control, init_routine);
> 
> Space before paren.

Updated patch attached.  OK to commit?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pthread_once-x86.patch
Type: text/x-patch
Size: 11955 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20141020/f9d8a53d/attachment.bin>


More information about the Libc-alpha mailing list