[PATCH 3/8] nptl: Fix testcases for new pthread cancellation, mechanism

[Joseph S. Myers]

On Thu, 9 Oct 2014, Adhemerval Zanella wrote:

> On 09-10-2014 11:55, Joseph S. Myers wrote:
> > On Thu, 9 Oct 2014, Adhemerval Zanella wrote:
> >
> >> open/open64     | tst-cancel4.c  |           no |        yes |
> >> pread/pread64   | tst-cancel4.c  |           no |        yes |
> >> pwrite/pwrite64 | tst-cancel4.c  |           no |        yes |
> > I don't think pairing like that is legitimate.  Each of those pairs is two 
> > separate functions, and only one of each pair is tested in tst-cancel4.c.  
> > The *64 functions need testing to at least the same extent.
> >
> Right, will be suffice to add proper tests for open64/pread64/pwrite64 using
> __USE_LARGEFILE64 on tst-cancel4.c to cover such cases?

You shouldn't need __USE_LARGEFILE64 (_GNU_SOURCE is used by default, 
which implies __USE_LARGEFILE64).  Yes, I think adding tests of those 
functions similar to the existing ones of open/pread/pwrite should 
suffice.

-- 
Joseph S. Myers
joseph@codesourcery.com