[PATCH] remove nested functions from elf/dl-lookup.c

Roland McGrath roland@hack.frob.com
Wed Oct 8 22:18:00 GMT 2014


> +/* We have to determine whether we already found a
> +   symbol with this name before.  If not then we have to
> +   add it to the search table.  If we already found a
> +   definition we have to use it.  */
[...]
> -  /* We have to determine whether we already found a
> -     symbol with this name before.  If not then we have to
> -     add it to the search table.  If we already found a
> -     definition we have to use it.  */

When you move a comment to a different indentation level, it's worth
hitting M-q just to see if it comes out prettier in fewer lines.

However, in this case the comment should not have been moved.
It's describing the logic of do_lookup_unique, not of enter.
The name "enter" is a bit too generic for a file-scope function.

I fixed these things up and committed for you.


Thanks,
Roland



More information about the Libc-alpha mailing list