[PATCH] remove nested functions from elf/dl-load.c

Konstantin Serebryany konstantin.s.serebryany@gmail.com
Wed Oct 1 23:08:00 GMT 2014


Hi,

Please review the patch that removes nested functions from elf/dl-load.c
I had to pack 4 parameters into a struct, just like with hack_digit in
stdio-common/printf_fp.c recently. With this patch the generated code
for _dl_rtld_di_serinfo is ~8 instructions
longer than in trunk (larger function prologue/epilogue) and add_path
is 2 instructions longer.

No regressions in 'make check' on x86_64-linux-gnu (Ubuntu 14.04)

2014-10-01  Kostya Serebryany  <konstantin.s.serebryany@gmail.com>

        * elf/dl-load.c
        (add_path): New function broken out of _dl_rtld_di_serinfo.
        (_dl_rtld_di_serinfo): Remove a nested function. Update call sites.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unnest-dl-load.patch
Type: text/x-patch
Size: 4046 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20141001/46b5cce1/attachment.bin>


More information about the Libc-alpha mailing list