[PATCH 4/N] [x86_64] Vectorized math functions

Joseph Myers joseph@codesourcery.com
Wed Nov 26 17:48:00 GMT 2014


On Fri, 21 Nov 2014, Andrew Senkevich wrote:

> +#ifndef _DATA_TABLE_OFFSETS_ONLY_

Rather than having such a macro and including one .S file from another, I 
think you should have a .h file with the offsets, and then include that .h 
files in all the .S files needing it.

I think this patch is in the wrong position in the patch series - rather 
than adding functions that aren't used, the series should first build up 
the architecture-independent infrastructure, then add the initial x86_64 
functions with the architecture-specific bits of the support for building 
and testing them.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list