BZ#14498: fix infinite loop in nss_db_getservbyname

Siddhesh Poyarekar siddhesh@redhat.com
Wed Nov 19 10:06:00 GMT 2014


On Thu, Nov 13, 2014 at 07:52:29PM -0200, Alexandre Oliva wrote:
> nss_db uses nss_files code for services, but a continue on protocol
> mismatch that doesn't affect nss_files skipped the code that advanced
> to the next db entry.  Any one of these changes would suffice to fix
> it, but fixing both makes them both safer to reuse elsewhere.
> 
> Regression tested on x86_64-linux-gnu.  Ok to install?
> 
> 
> for  ChangeLog
> 
> 	[BZ #14498]
> 	* NEWS: Fixed.
> 	* nss/nss_db/db-XXX.c (_nss_db_get##name##_r): Update hidx
> 	after parsing line but before break_if_match.
> 	* nss/nss_files/files-service (DB_LOOKUP): Don't "continue;"
> 	if there is a protocol mismatch.

Looks good to me.

Thanks,
Siddhesh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20141119/272f6e34/attachment.sig>


More information about the Libc-alpha mailing list