[Patch] Speed up strcoll by inlining

[Ondřej Bílka]

On Sun, Nov 16, 2014 at 10:33:35AM +0100, Leonhard Holz wrote:
> My development machine is a virtual 32-bit Ubuntu 14.10 Linux:
> 
> gcc --version: gcc (Ubuntu 4.9.1-16ubuntu6) 4.9.1
> uname -a: Linux leo-VirtualBox 3.16.0-24-generic #32-Ubuntu SMP Tue
> Oct 28 13:13:18 UTC 2014 i686 i686 i686 GNU/Linux
> 
> Best,
> Leonhard
> 
> Am 16.11.2014 09:50, schrieb Andrew Pinski:
> >On Sun, Nov 16, 2014 at 12:47 AM, Leonhard Holz <leonhard.holz@web.de> wrote:
> >>This patch improves the performance of strcoll_l by inlining the two helper
> >>functions get_next_seq and do_compare.
> >
> >
> >Can you say which version of GCC you are using?  And on what target.
> >Also maybe this should be analysed by the GCC folks to figure out why
> >those two functions are not inlined.
> >
It is not surprising, get_next_seq is 120 lines long and called twice so
gcc will not inline it based on size. As do_compare is called once it
should be inlined so difference is entirely from get_next_seq.