[PATCH v2] Add x86 32 bit vDSO time function support

[Nathan Lynch]

On 11/05/2014 06:51 AM, Adhemerval Zanella wrote:
> On 03-11-2014 21:51, Nathan Lynch wrote:
>>> i386 does not define HAVE_CLOCK_GETTIME_VSYSCALL and thus:
>>>
>>> sysdeps/unix/sysv/linux/clock_gettime.c:
>>>
>>>  26: # define INTERNAL_VSYSCALL INTERNAL_SYSCALL
>>>
>>> and then if INTERNAL_GETTIME is not defined, it will as:
>>>
>>>  37 #ifndef INTERNAL_GETTIME
>>>  38 # define INTERNAL_GETTIME(id, tp) \
>>>  39   INTERNAL_VSYSCALL (clock_gettime, err, 2, id, tp)
>>>  40 #endif
>>>
>>> And without proper set the PTR_DEMANGLE is not called either.
>> I think my point might be better expressed as: why is INTERNAL_GETTIME
>> defined in linux/clock_gettime.c at all?  It is not used in the
>> clock_gettime implementation.
>>
>> The only use in glibc of a macro by that name is in
>> linux/timespec_get.c, and the arch can override it in its own
>> timespec_get.c (as x86_64 currently does).
>>
> I see your point and I removed its definition now for x86. Below it's the revised
> patchset.


I have no further concerns, thanks.