[PATCH 5/5] PowerPC: Move remaining, nptl/sysdeps/unix/sysv/linux/powerpc/ files.
Roland McGrath
roland@hack.frob.com
Fri May 23 22:11:00 GMT 2014
When you are posting a change that is largely verbatim file moves, and
especially if you aren't expecting people to apply the patch themselves
with 'patch' (because you supplied a git branch, or because you advise
people they'll have to use 'git apply'), using 'git diff --renames' makes
the diff a lot easier to review.
> * nptl/sysdeps/unix/sysv/linux/powerpc/Makefile: Moved ...
> * sysdeps/unix/sysv/linux/powerpc/nptl/Makefile: ... here.
Not helpful. At the end of the day, there should not be a
sysdeps/unix/sysv/linux/powerpc/nptl/ subdirectory at all. You need to
merge the nptl/.../Makefile contents into the existing
sysdeps/unix/sysv/linux/powerpc/Makefile instead. Note that they
really should have an 'ifeq ($(subdir),nptl)' conditional that the
old Makefile was missing.
The rest looks fine off hand.
Thanks,
Roland
More information about the Libc-alpha
mailing list