FW: [PATCH 2/2] ARM: Improve fenv implementation
Wilco
wdijkstr@arm.com
Mon May 19 17:26:00 GMT 2014
> Joseph Myers wrote:
> This breaks the build when VFP isn't enabled at compile-time, because then
> the libc_* functions aren't defined. You need to have the <fenv.h>
> functions conditionally call libc_* functions that always use VFP (and are
> always defined), while those VFP-using functions are only conditionally
> used within the rest of libm. I.e., I think the __SOFTFP__ conditionals
> in fenv_private.h should only control the definitions of libc_* to use
> libc_*_vfp, not the definitions of the libc_*_vfp inlines.
You're right, it wouldn't build properly. I'll move the #ifndef __SOFTFP__
to go just before the defines and add the reverted patch to my outstanding
patch set.
Any chance we can obsolete softfp only builds any time soon? I can't
remember when the last non-VFP ARM was made, but it must have been at
least a decade ago... Are those NetWinder boards still working/in use?
Wilco
More information about the Libc-alpha
mailing list